aboutsummaryrefslogtreecommitdiff
path: root/tests/test_client.py
diff options
context:
space:
mode:
authorCody Logan <cody@lokken.dev>2023-11-06 12:18:46 -0800
committerCody Logan <cody@lokken.dev>2023-11-06 12:18:46 -0800
commit3d34b09a361dadb50bb4e4ffa18c75928904c30d (patch)
tree3439106e06fedbc9c9030462971818c89c90631f /tests/test_client.py
parent2d18a4cefff6f26a48966e66774c463dfbbe2492 (diff)
downloadwikiget-3d34b09a361dadb50bb4e4ffa18c75928904c30d.tar.gz
wikiget-3d34b09a361dadb50bb4e4ffa18c75928904c30d.zip
Simplify mock usage in tests
Diffstat (limited to 'tests/test_client.py')
-rw-r--r--tests/test_client.py12
1 files changed, 5 insertions, 7 deletions
diff --git a/tests/test_client.py b/tests/test_client.py
index 45739d3..207d9b2 100644
--- a/tests/test_client.py
+++ b/tests/test_client.py
@@ -16,11 +16,10 @@
# along with Wikiget. If not, see <https://www.gnu.org/licenses/>.
import logging
-from unittest.mock import MagicMock, patch
+from unittest.mock import MagicMock, patch, sentinel
import pytest
-from mwclient import InvalidResponse, Site
-from mwclient.image import Image
+from mwclient import InvalidResponse
from requests import ConnectionError, HTTPError
from wikiget import DEFAULT_SITE
@@ -113,9 +112,8 @@ class TestQueryApi:
# would have created using the MediaWiki API. The Site.images attribute is
# normally populated during Site init, but since we're not doing that, a mock
# dict is created for query_api to parse.
- mock_site = MagicMock(Site)
- mock_image = MagicMock(Image)
- mock_site.images = {"Example.jpg": mock_image}
+ mock_site = MagicMock()
+ mock_site.images = {"Example.jpg": sentinel.mock_image}
image = query_api("Example.jpg", mock_site)
- assert image == mock_image
+ assert image == sentinel.mock_image